[C#] SHA1 & MD5 Hashing

[IcyJake wats good Posts:587 Threads:340 Reputation 15]

I got bored the other day and I don't visit this forum that much and I'm gonna try to change that, so to start that off, I'm going to share my class with you guys.

Code:

public class Hash
    {
        public string SHA1(string input)
        {
            byte[] hash;
            using (var sha1 = new System.Security.Cryptography.SHA1CryptoServiceProvider())
            {
                hash = sha1.ComputeHash(Encoding.Unicode.GetBytes(input));
            }
            var sb = new StringBuilder();
            foreach (byte b in hash) sb.AppendFormat("{0:x2}", b);
            return sb.ToString();
        }
        public string MD5(string input)
        {
            MD5 md5 = new MD5CryptoServiceProvider();
            string pass = Console.ReadLine();
            byte[] checkSum = md5.ComputeHash(Encoding.Unicode.GetBytes(input));
            string result = BitConverter.ToString(checkSum).Replace("-", String.Empty);
            return result.ToLower();
        }
    }

If you guys encounter any problems, just apprise me about it and I will try to implement some kind of fix to any problems. Enjoy. 

[adz8cika1 DF Member Posts:14 Threads:2 Reputation 0]

code looks good danke

[IcyJake wats good Posts:587 Threads:340 Reputation 15]

code looks good danke

Thanks a lot man!!

[FTPService DF Member Posts:13 Threads:3 Reputation 0]

Code is a bit messy but thanks for the share :)

[IcyJake wats good Posts:587 Threads:340 Reputation 15]

Code is a bit messy but thanks for the share :)

How is it messy? Also, you're welcome.

[bitm0de DF Member Posts:15 Threads:3 Reputation 5]

Code is a bit messy but thanks for the share :)

How is it messy? Also, you're welcome.

Well they both use 2 entirely different methods to get the hex string for starters. And the 2nd method doesn't dispose of the MD5 provider.

[leeac DF Member Posts:2 Threads:1 Reputation 0]

You should use "var" always you can, like when you did "string pass" or "string result". Not big deal but it improve your code

[Testingout123 DF Member Posts:15 Threads:0 Reputation 0]

looks great dude keep up the work